mARTin-B78/My-Weekly-ToDo-List
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: auto-prune deleted Synology calendars during event fetch

Browse Source 
When a Synology calendar returns 404 during event fetch, remove it from
the stored calendar list instead of silently returning empty results.

v1.57.4

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
mARTin 2026-03-22 23:06:02 +01:00
parent 87d78d78b5
commit 93e808ddfa
3 changed files with 24 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
package.json
View File

@ -1,6 +1,6 @@
{ {
"name": "my-weekly-todo-list", "name": "my-weekly-todo-list",
"version": "1.57.3", "version": "1.57.4",
"description": "A web-based weekly task management application that organizes to-dos and calendar events in a single, intuitive weekly view", "description": "A web-based weekly task management application that organizes to-dos and calendar events in a single, intuitive weekly view",
"main": "index.js", "main": "index.js",
"scripts": { "scripts": {

18
src/lib/calendar-events.ts
View File

@ -518,8 +518,22 @@ export const getCalendarEvents = async (
attachments: event.attachments as EventAttachment[] || undefined, attachments: event.attachments as EventAttachment[] || undefined,
}; };
})); }));
} catch (calError) { } catch (calError: any) {
console.error(`[CALENDAR] Synology: error fetching events from calendar ${calendarId}:`, calError); const msg = calError?.message || '';
if (msg.includes('not found') || msg.includes('Not found') || calError?.status === 404) {
console.warn(`[CALENDAR] Synology: calendar ${calendarId} not found, removing from stored list`);
calendars = calendars.filter((c: any) => c.id !== calendarId);
try {
await prisma.calendarConnection.update({
where: { id: connection.id },
data: { calendars: calendars },
});
} catch (dbErr) {
console.error('[CALENDAR] Synology: failed to prune calendar from DB:', dbErr);
}
} else {
console.error(`[CALENDAR] Synology: error fetching events from calendar ${calendarId}:`, calError);
}
} }
} }
} else if (connection.provider === 'outlook') { } else if (connection.provider === 'outlook') {

9
src/lib/synology-calendar.ts
View File

@ -372,8 +372,13 @@ export const getUpcomingEvents = async (
} catch (error: any) { } catch (error: any) {
const msg = error?.message || ''; const msg = error?.message || '';
const status = error?.response?.status || error?.status; const status = error?.response?.status || error?.status;
// Silently handle expected failures (stale/deleted calendars, permission issues) // Re-throw 404 so callers can prune deleted calendars
if (status === 405 || status === 404 || msg.includes('405') || msg.includes('Not Allowed') || msg.includes('not found')) { if (status === 404 || msg.includes('not found') || msg.includes('Calendar not found')) {
console.warn(`[SYNOLOGY CALENDAR] Calendar not found: ${calendarUrl}`);
throw error;
}
// Silently handle other expected failures (permission issues, method not allowed)
if (status === 405 || msg.includes('405') || msg.includes('Not Allowed')) {
console.warn(`[SYNOLOGY CALENDAR] Calendar unavailable (${status || msg.slice(0, 60)}): ${calendarUrl}`); console.warn(`[SYNOLOGY CALENDAR] Calendar unavailable (${status || msg.slice(0, 60)}): ${calendarUrl}`);
} else { } else {
console.error(`[SYNOLOGY CALENDAR] Error fetching events for ${calendarUrl}:`, error); console.error(`[SYNOLOGY CALENDAR] Error fetching events for ${calendarUrl}:`, error);