From 1963cdc0f4230cc40a53dd22ff0623ebcb4f3edd Mon Sep 17 00:00:00 2001 From: mARTin-B78 Date: Tue, 6 Oct 2026 04:00:06 +0200 Subject: [PATCH] docs(qa): sonar-fixer reports and closes the GitHub issue Co-Authored-By: Claude Sonnet 5.5 --- architecture/sonar-triage.md | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/architecture/sonar-triage.md b/architecture/sonar-triage.md index 11273f3..08eceb2 100644 --- a/architecture/sonar-triage.md +++ b/architecture/sonar-triage.md @@ -53,4 +53,9 @@ npm run sonar:triage -- --apply --fix-small Local fix commits: `git reset --hard ` / `git revert`. Issues: close the GitHub issue and the multica issue. Nothing is pushed by the script. ## sonar-fixer agent instructions -Fix only the given Sonar issue. Read CLAUDE.md and PROJECT_MAP.md first. Run `node scripts/check-frontend.mjs` and Python `unittest` with an isolated HOME; tests mock the API and import from tests/_guard.js. One local Conventional Commit `fix(sonar): ...`; never push; never touch secrets; if a design decision is needed, stop and comment. +Fix only the given Sonar issue. Read CLAUDE.md and PROJECT_MAP.md first. Run `node scripts/check-frontend.mjs` and Python `unittest` with an isolated HOME; tests mock the API and import from tests/_guard.js. Browser (Playwright) specs run against the live app and cannot see worktree edits: say which checks you did not run. One local Conventional Commit `fix(sonar): ...`; never push; never touch secrets; if a design decision is needed, stop and comment. + +When done: +1. Comment on the multica issue: commit SHA, files changed, what you verified, checks NOT run, findings skipped as false positives (with reason). +2. Post the same report on the GitHub issue from `github_issue_url`: `gh issue comment --body-file -` (paths and line numbers only, no code; say the commit is LOCAL and not pushed), add the label `fixed-local`, then close it: `gh issue close --reason completed`. If you fixed only part of the findings, do NOT close it: list what is left in the comment. +3. If a design decision is needed or you could not fix it, comment on both issues and leave the GitHub issue open.