mARTin-B78/tts-voice-creator-clone-and-design-2
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix assign popup being closed before a name-elsewhere click could fill it (v1.14.14)

Browse Source 
A document-level "click outside closes the popup" handler only exempted
clicks on the paragraph's speaker label, not clicks anywhere else in the
passage text. Since mousedown fires before click, this closed the popup
(clearing assignModeRow) before the v1.14.13 name-click logic ever ran,
making "click a name elsewhere to feed the open popup" silently do
nothing. Passage-text clicks/drags no longer auto-close the popup.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
mARTin-B78 2026-07-09 02:44:10 +02:00
parent cd20df315d
commit 83808a22e1
4 changed files with 17 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
CHANGELOG.md
View File

@ -9,6 +9,13 @@ Follows [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) · versioned wi
---
## [1.14.14] — 2026-07-09
### Fixed
- **Clicking a name elsewhere in the text to feed an already-open "Assign to" popup did nothing** — a separate document-level "click outside closes the popup" handler only exempted clicks on the paragraph's own speaker label, not clicks anywhere else in the passage text. So the popup was being closed by mousedown before the (v1.14.13) name-click logic ever got to run. Clicks and drag-selections inside passage text no longer auto-close the popup.
---
## [1.14.13] — 2026-07-09
### Fixed

2
VERSION
View File

@ -1 +1 @@
1.14.13
1.14.14

6
static/index.html
View File

@ -10,7 +10,7 @@
<meta name="format-detection" content="telephone=no">
<meta name="color-scheme" content="light dark">
<meta name="theme-color" content="#2563EB">
<meta name="app-version" content="1.14.13">
<meta name="app-version" content="1.14.14">
<link rel="manifest" href="/manifest.webmanifest">
<link rel="icon" href="/static/icon.svg" type="image/svg+xml">
<link rel="apple-touch-icon" href="/static/icon.svg">
@ -27,7 +27,7 @@
<!-- ── Core styles (local — no CDN dependency for first paint) ────────── -->
<link rel="stylesheet" href="/static/vendor/mdi/materialdesignicons.min.css">
<link rel="stylesheet" href="/static/style.css?v=1.14.13">
<link rel="stylesheet" href="/static/style.css?v=1.14.14">
<!-- ── Flag icons — non-blocking (loaded async, icons appear after JS) ── -->
@ -365,7 +365,7 @@ window.toggleNavTree = function(treeId, chevronId) {
</script>
<!-- loader.js: fetches sections → loads JS modules → removes skeleton -->
<script src="/static/loader.js?v=1.14.13"></script>
<script src="/static/loader.js?v=1.14.14"></script>
</body>
</html>

7
static/js/audiobook.js
View File

@ -2574,7 +2574,12 @@ STRIKTE FORMAT- UND TEXTREGELN:
header.querySelector('.mdi-close').addEventListener('click', () => assignPopup._close?.());
document.addEventListener('mousedown', e => {
if (assignPopup.style.display !== 'none' && !assignPopup.contains(e.target) && !e.target.closest('.ab-cv-spk')) {
// Don't auto-close on a click/drag inside the passage text either — that's
// exactly how you feed a name into an already-open popup (see the feed's
// click and mouseup handlers below), so closing here on mousedown would
// kill the popup before that logic ever runs.
if (assignPopup.style.display !== 'none' && !assignPopup.contains(e.target)
&& !e.target.closest('.ab-cv-spk') && !e.target.closest('.ab-cv-txt')) {
assignPopup._close?.();
}
});