mARTin
d92a8c7210
- Added 'onDelete' and 'onNotes' support to TaskItem. - Implemented hover actions (Delete and Notes icons) for tasks. - Added Notes Modal for editing task markdown content. - Simplified navigation animation to remove blank flash (single-phase slide-in). - Fixed syntax error in updateTask function. - Updated styles for modal and task actions.
36 lines
1018 B
Markdown
36 lines
1018 B
Markdown
---
|
|
title: Do not wrap a simple expression with a primitive result type in useMemo
|
|
impact: LOW-MEDIUM
|
|
impactDescription: wasted computation on every render
|
|
tags: rerender, useMemo, optimization
|
|
---
|
|
|
|
## Do not wrap a simple expression with a primitive result type in useMemo
|
|
|
|
When an expression is simple (few logical or arithmetical operators) and has a primitive result type (boolean, number, string), do not wrap it in `useMemo`.
|
|
Calling `useMemo` and comparing hook dependencies may consume more resources than the expression itself.
|
|
|
|
**Incorrect:**
|
|
|
|
```tsx
|
|
function Header({ user, notifications }: Props) {
|
|
const isLoading = useMemo(() => {
|
|
return user.isLoading || notifications.isLoading
|
|
}, [user.isLoading, notifications.isLoading])
|
|
|
|
if (isLoading) return <Skeleton />
|
|
// return some markup
|
|
}
|
|
```
|
|
|
|
**Correct:**
|
|
|
|
```tsx
|
|
function Header({ user, notifications }: Props) {
|
|
const isLoading = user.isLoading || notifications.isLoading
|
|
|
|
if (isLoading) return <Skeleton />
|
|
// return some markup
|
|
}
|
|
```
|