mARTin
d92a8c7210
- Added 'onDelete' and 'onNotes' support to TaskItem. - Implemented hover actions (Delete and Notes icons) for tasks. - Added Notes Modal for editing task markdown content. - Simplified navigation animation to remove blank flash (single-phase slide-in). - Fixed syntax error in updateTask function. - Updated styles for modal and task actions.
40 lines
973 B
Markdown
40 lines
973 B
Markdown
---
|
|
title: Defer State Reads to Usage Point
|
|
impact: MEDIUM
|
|
impactDescription: avoids unnecessary subscriptions
|
|
tags: rerender, searchParams, localStorage, optimization
|
|
---
|
|
|
|
## Defer State Reads to Usage Point
|
|
|
|
Don't subscribe to dynamic state (searchParams, localStorage) if you only read it inside callbacks.
|
|
|
|
**Incorrect (subscribes to all searchParams changes):**
|
|
|
|
```tsx
|
|
function ShareButton({ chatId }: { chatId: string }) {
|
|
const searchParams = useSearchParams()
|
|
|
|
const handleShare = () => {
|
|
const ref = searchParams.get('ref')
|
|
shareChat(chatId, { ref })
|
|
}
|
|
|
|
return <button onClick={handleShare}>Share</button>
|
|
}
|
|
```
|
|
|
|
**Correct (reads on demand, no subscription):**
|
|
|
|
```tsx
|
|
function ShareButton({ chatId }: { chatId: string }) {
|
|
const handleShare = () => {
|
|
const params = new URLSearchParams(window.location.search)
|
|
const ref = params.get('ref')
|
|
shareChat(chatId, { ref })
|
|
}
|
|
|
|
return <button onClick={handleShare}>Share</button>
|
|
}
|
|
```
|